How should we patch authlib to fix skins?
Closed this issue · 13 comments
https://account.server.org/users/profiles/minecraft/name returns http code 500
I get internal server error going to any api, yet game still works
every page, it seems, at least in my browser returns http code 500
Console says "Not found" but how? this is standard yggdrasil api stuff
It uploads via website, i can see it on my launcher, but it does not work on the server... strange... ^ I think now that the api could be working fine, it is just something I am doing wrong. I'm new to working with this, apologies
authlib-injector had issue with skins in 1.19.4 that got fixed in the most recent update, but im not sure if its related
Hey! Yes, this project is indev so to speak and pretty much only the bare minimum API routes are implemented so far, that's why https://account.server.org/users/profiles/minecraft/name isn't working for you. I actually did implement that route but I incorrectly put it under the "services" enpoint rather than the "account" endpoint, whoops.
But skins should work both in Prism Launcher and in the game, with a catch. The vanilla Minecraft client refuses to load skins from non-Mojang domains, and I'm guessing that's what's happening in your case. You can fix that with this Fabric mod: https://github.com/unmojang/DraslTweaks. I just updated it for 1.19.4 but I'd like to support all recent versions of Minecraft eventually.
Out of curiosity, are you using the patched Prism Launcher or PolyMC here? PrismLauncher/PrismLauncher#543 Or some other launcher?
Hey! Yes, this project is indev so to speak and pretty much only the bare minimum API routes are implemented so far, that's why https://account.server.org/users/profiles/minecraft/name isn't working for you. I actually did implement that route but I incorrectly put it under the "services" enpoint rather than the "account" endpoint, whoops.
But skins should work both in Prism Launcher and in the game, with a catch. The vanilla Minecraft client refuses to load skins from non-Mojang domains, and I'm guessing that's what's happening in your case. You can fix that with this Fabric mod: https://github.com/unmojang/DraslTweaks. I just updated it for 1.19.4 but I'd like to support all recent versions of Minecraft eventually.
Out of curiosity, are you using the patched Prism Launcher or PolyMC here? PrismLauncher/PrismLauncher#543 Or some other launcher?
ohh thanks, i didnt see this fabric mod. But I would prefer if the solution was simpler than that. The auth server I use rn fixes this with a java class injector thing called authlib-injector. I think you could modify your prism fork to include a java program that injects into the auth lib and have the flag to inject it be automatically inserted if the account being used is a custom auth server
also, i really do encourage you to continue on this project. The auth system i am using rn feels very bloated and I like simpler things with less moving parts (js and such), to keep it easy to modify for my interests
Bump, please consider the above solution for better futureproofing (since mods need to be remade every version)
I think a good idea would be to add support for authlib-injector, incase someone prefers it. Here is the code for how api URLs are remapped
And here is how option for custom server is parsed
ohh thanks, i didnt see this fabric mod. But I would prefer if the solution was simpler than that. The auth server I use rn fixes this with a java class injector thing called authlib-injector. I think you could modify your prism fork to include a java program that injects into the auth lib and have the flag to inject it be automatically inserted if the account being used is a custom auth server
Yeah, I'm a little lukewarm on authlib-injector's approach, see PrismLauncher/PrismLauncher#543 (comment). And I'm doubtful I could get something like that merged into Prism. But this more automatic functionality may be appropriate to implement if I end up maintaining a fork of Prism Launcher.
Bump, please consider the above solution for better futureproofing (since mods need to be remade every version)
Yes, that's a big downside of the Fabric approach. TBH I don't know much about modding, there might be a way to make a mod that is somewhat resilient to updates and that can work on many versions. Historically, authlib hasn't changed much version-to-version, but we will see whether 1.19 will mark the start of a change in that trend, or whether these recent changes were just a one-off thing.
I think a good idea would be to add support for authlib-injector, incase someone prefers it. Here is the code for how api URLs are remapped
Strongly agree, it seems to be the dominant way people currently use custom API servers. I opened #6.
also, i really do encourage you to continue on this project. The auth system i am using rn feels very bloated and I like simpler things with less moving parts (js and such), to keep it easy to modify for my interests
Thank you very much, I appreciate your interest! Yes, one of my goals is to make it extremely easy to deploy, configure, and modify to suit a wide variety of use cases. And to keep the web interface highly accessible and minimalistic, only using JavaScript for extra visuals like the skinview3d preview.
The https://account.drasl.example.org/users/profiles/minecraft/<playerName> and most other Mojang routes are implemented now, but I may keep this issue open for a bit to discuss options for patching authlib.
Yeah, I'm a little lukewarm on authlib-injector's approach, see PrismLauncher/PrismLauncher#543 (comment). And I'm doubtful I could get something like that merged into Prism. But this more automatic functionality may be appropriate to implement if I end up maintaining a fork of Prism Launcher.
I do urge you to maintain a prism fork. A makedeb and makepkg will cover debian and arch based binaries, which is the majority of what you need to deal with. Arch pkgbuild can just be on aur too and not need a build server
The https://account.drasl.example.org/users/profiles/minecraft/ and most other Mojang routes are implemented now, but I may keep this issue open for a bit to discuss options for patching authlib.
Awesome to hear
Closing now that PollyMC supports custom auth servers: https://github.com/fn2006/PollyMC.