unosquare/tubular-react

Column filtering doesn't work in first example

jenkin opened this issue · 4 comments

Describe the bug
In this example listed in README some columns are defined with filtering: true but no filter icon is shown.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/tubular-react-template-gyjo8
  2. Wait for loading
  3. No filter is shown

Expected behavior
With filtering: true no filter is shown. BUT with filterable: true (file src/Main.jsx) it works! BUT if you upgrade tubular-react from v4.1.25 to v4.1.35 (file package.json), neither the first nor the second option works. The issue seems to occur from v4.1.27 included.

Desktop (please complete the following information):
CodeSandbox with Chromium Version 80.0.3987.162 (Build) built on Debian 10.3, running on Debian 10.4 (a 64 bit)

Hi @jenkin,

We're in the middle of several changes. One of them was to remove filter features from the column component. The latest version contains filter features inside a drawer. Give me a few to provide a codesandbox.

Ok, for now I stick to v4.1.26 and wait for updates, thanks!

Hey @jenkin, please check the following codesandbox:
https://codesandbox.io/s/tubular-react-template-n042f

As you can see:

  1. The property for the column is filterable
  2. In order to filter a column, there's a new toolbar button to open column filters

image

I'll close this one since there is not really an issue and we're working on updating the Readme to avoid any further misunderstanding.

This is the ticket for that effort: #814