Change mention of DockerHub
Roxedus opened this issue · 5 comments
Now that other registries are gaining traction, and people and organizations moving away from DockerHub (for hopefully obvious reasons) I would like this string to be platform-independent.
I don't quite know how intricate changing the string actually is, I would imagine it would be just updating the referenced line.
2 options. You can change the text there AND on line 37 in https://github.com/unraid/lang-en_US/blob/master/docker.txt
or you can leave the first alone and add in "replacement text" after the equal sign in the 2nd. No "simple" solution due to translations being present.
First option winds up removing any translations for the line already done and substituting English, whereas the second option doesn't and makes the English match the concept you're trying to convey but leaves the translations solely referencing dockerHub
I would ideally opt for option 1, as that would be technically correct, however I do see the implications. I think I'm going to leave this as a issue then, as I do not see this as my decision to make.
Is there a process or better a suited place for discussing changes like this that would break translations?
You do whatever PR(s) you're comfortable with, then the comments happen upon it and @limetech makes the decision.
Or wait for @limetech to chime in here.
A third option is to add a new line into docker.txt to match the text you're setting in CreateDocker.php, with the result that all existing translations would be missing the translation and have English substituted, but makes more "sense". My personal thought is #2 for something this minor, but not my decision
Update done (https://github.com/limetech/webgui/pull/1216/files). This issue can be closed.
Thanks