v6.0.0 might be missing some exports
mikeymop opened this issue · 4 comments
Hello,
I'm working with this module on yoroi-mobile and tried updating from v5.0.2 to v6.0.0 and when building the application is fails when bundling the module.
I am not exactly sure whats wrong but I believe there is a missing export somewhere in the UNS portion of the library. Can you lend some advice?
BUNDLE ./index.ts
error: Error: While trying to resolve module `.` from file `/node_modules/@unstoppabledomains/resolution/build/UnsInternal.js`, the package `/node_modules/@unstoppabledomains/resolution/build/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved (`/node_modules/@unstoppabledomains/resolution/build/build/index.js`. Indeed, none of these files exist:
* /node_modules/@unstoppabledomains/resolution/build/build/index.js(.native|.android.js|.native.js|.js|.android.jsx|.native.jsx|.jsx|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx|.android.json|.native.json|.json)
* /node_modules/@unstoppabledomains/resolution/build/build/index.js/index(.native|.android.js|.native.js|.js|.android.jsx|.native.jsx|.jsx|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx|.android.json|.native.json|.json)
at DependencyGraph.resolveDependency (/node_modules/metro/src/node-haste/DependencyGraph.js:436:17)
at Object.resolve (/node_modules/metro/src/lib/transformHelpers.js:317:42)
at resolve (/node_modules/metro/src/DeltaBundler/traverseDependencies.js:629:33)
at /node_modules/metro/src/DeltaBundler/traverseDependencies.js:645:26
at Array.reduce (<anonymous>)
at resolveDependencies (/node_modules/metro/src/DeltaBundler/traverseDependencies.js:644:33)
at /node_modules/metro/src/DeltaBundler/traverseDependencies.js:329:33
at Generator.next (<anonymous>)
at asyncGeneratorStep (/node_modules/metro/src/DeltaBundler/traverseDependencies.js:137:24)
at _next (/node_modules/metro/src/DeltaBundler/traverseDependencies.js:159:9)
/node_modules/metro-hermes-compiler/src/emhermesc.js:81
throw ex;
^
Error: ENOENT: no such file or directory, watch '/node_modules/@emurgo/react-native-haskell-shelley/android/build/outputs/logs'
at FSWatcher.<computed> (internal/fs/watchers.js:243:19)
at Object.watch (fs.js:1586:34)
at NodeWatcher.watchdir (/node_modules/sane/src/node_watcher.js:159:22)
at NodeWatcher.<anonymous> (/node_modules/sane/src/node_watcher.js:295:18)
at FSReqCallback.oncomplete (fs.js:192:5) {
errno: -2,
syscall: 'watch',
code: 'ENOENT',
path: '/node_modules/@emurgo/react-native-haskell-shelley/android/build/outputs/logs',
filename: '/node_modules/@emurgo/react-native-haskell-shelley/android/build/outputs/logs'
}
error Command failed with exit code 7.
Hi @mikeymop . Could you provide a smallest sample of environment and the code to reproduce the issue? Thanks!
@mikeymop Since UnsInternal is not intended to be exported we consider this as expected behaviour. But it would be great to get more details from you and investigate this issue properly.
@mikeymop I've removed all relative path imports using '.' as path. I'm unsure whether it helps since i can't reproduce this in my ENV. Would be great if you can give it a try.
Fix is deployed in 6.0.3 version https://github.com/unstoppabledomains/resolution/tree/v6.0.3
Thank you!