upbound/platform-ref-aws

Team Name and vpc name are hardcoded in composition

AaronME opened this issue · 2 comments

What happened?

Latest updates are now hardcoding some tags in the composition which might not align with consumer needs:

How can we reproduce it?

This was discovered while running kuttl tests from https://github.com/AaronME/ATourOfCrossplane/tree/main/crossplane-package-testing-with-kuttl

What environment did it happen in?

Local testing

Thank you for bringing it up @AaronME . It was added to show that some tags can always be added from within the composition rather than claim. Those tags cannot be overridden on purpose. Do you think this should be removed?

we removed the hardcoded tags via #116 - will open a follow up for function labels and tags ;)