uplink42/etmv2

Citadel taxes settings are not handled properly/Originating station not taken into account

Closed this issue · 1 comments

The citadel and npc station tax settings are not used correctly when calculating profit (for instance in profit breakdown view).

Could it be that the settings only effect new orders? Is the calculated data saved after importing?

I am using both settings:

Set all Citadel taxes to zero: true
Set all NPC station taxes to zero: true

I am expecting that only sell orders get a broker fee OR neither buy or sell get a broker fee. However, it seems they both do.

I've tested with a small bunch of trit to keep straight forward calculations.

100k trit
buy: 4,54 
total: 454.000 
after tax(0.1% citadel broker fee): 454.454 isk 
sell: 4,74 total 
total: 474.000
after tax (2.6% + 1.2%):  455.988 isk

Profit: 0.33%

However due to ETM taking the same broker fee for buy orders it reports a profit of : -2.3%

It seems the setting is only used for new orders so it is probably working as intended. Closing the issue