Manage indentation with textwrap

Question

Manage indentation with textwrap

Opened this issue 5 years ago · 9 comments

Since python2 will not be maintained soon, according to DRY, may be it would be a good idea to replace (make aliases) dill indentation methods with ones from core library?
For example, dill.source.indent with textwrap.indent, dill.source.outdent with textwrap.dedent.

If python2 support is critical, then dill methods could be refactored, using python2.7 textwrap.

If the idea is acceptable in general, I could provide a patch.

Answer 1 · 2019-10-07T09:41:55.000Z

Looks unnecessary.

Answer 2 · 2019-10-07T13:14:11.000Z

Thanks for the thoughts @opavlyuk, I'll look at what you suggest regardless.

Answer 3 · 2019-10-08T10:05:21.000Z

@mmckerns Thanks, may be it might be useful for the project.

Answer 4 · 2020-11-02T00:39:20.000Z

Kicking this down the road a bit. Support for 2.7 will end soon, so that's probably the appropriate time to deal with this.

Answer 5 · 2021-06-13T17:32:20.000Z

Support for 2.7 will end before dill-0.3.5 #413

Answer 6 · 2022-05-19T23:14:51.000Z

dill-0.3.6 will not support 2.7, support will be dropped imminently

Answer 7 · 2022-05-25T19:43:58.000Z

2.7 is no longer supported

Answer 8 · 2022-07-16T13:23:22.000Z

There's a difference in the intent:
textwrap.dedent(text) and textwrap.indent(text, prefix, predicate=None)
are intended to shift text, while dill.source.indent(code, spaces=4) and dill.source(code, spaces=None, all=True) is intended to (identify and) shift blocks of code (e.g. inside a def).

I think one would need a bunch of existing logic with only a little replaced with dedent. While on the other hand, dill.source.indent may be able to build a complex predicate or predicates that can replace most of its code.

Will need more investigation...

Answer 9 · 2022-07-24T02:34:29.000Z

I'm going to punt this (again) to the next milestone, and come back to it after the pending release.