uqm-arena/balance-mod

[ISSUE][CLOSED] Game ends even though both sides have ships left (no-retreat)

Closed this issue · 9 comments

Issue by SirDifferential
Friday Dec 21, 2012 at 14:55 GMT
Originally opened as https://github.com/SirDifferential/Shiver-Balance-Mod/issues/30


When both sides still have ships left the game is at times ended as if one side had lost. This has happened a few times in past. In this instance the situation was as follows:

One side had lost all but 3 ships: Ilwrath, Orz and Druuge. This side was flying an Androsynth, which died in combat, ending the entire game. The other side had 10 ships left.

Comment by SirDifferential
Friday Dec 21, 2012 at 15:48 GMT


This is probably the same bug: At times the game expects one side to pick a ship even though he has none left.

Comment by xaionaro
Thursday Jan 31, 2013 at 21:22 GMT


I thought this bug was been fixed. There were been a problem with "battle_counter" decrementing on each warp-out.

Is the problem still exists?

Comment by oldlaptop
Saturday May 11, 2013 at 00:34 GMT


Thanks to psydev for a very useful report about this bug on IRC. He played a game against the AI and had the bug happen as described. A Shofixti destroyed his Pkunk with the Glory Device; he respawned, but the victory ditty for Shofixti played and he got a green reticle on Pkunk (bug #31). The AI then destroyed Pkunk with an Androsynth, resulting in this bug. The Pkunk had respawned at least twice before this; each side had four ships left when the bug occured. So we know for sure that it doesn't need the network to happen now, and Pkunk is certainly implicated.

Comment by xaionaro
Thursday Aug 01, 2013 at 12:58 GMT


I'll try to repeat this, soon.. If I'll not forget :(

Comment by oldlaptop
Friday Aug 02, 2013 at 03:09 GMT


This seems to be caused by the game counting Pkunk respawns as ship losses somehow. When one side uses Pkunk and it respawns a certain number of times, the game will end the match when the side using Pkunk has that number of ships left. This seems to be perfectly reproducible.

Comment by xaionaro
Friday Aug 02, 2013 at 04:56 GMT


That's strange, because, IIRC, when I played UQM the last time (half-year ago) there wasn't such bug.

Anyway, seems, that there will be time to check/fix this in this Sunday. :)

Comment by oldlaptop
Friday Aug 02, 2013 at 19:24 GMT


I think this is solved in e2e80ef, please test!

Comment by xaionaro
Sunday Aug 04, 2013 at 16:11 GMT


I cannot repeat the bug on current git version.

Comment by SirDifferential
Monday Aug 05, 2013 at 05:33 GMT


Confirmed, it's fixed