uranium62/xxHash

Public APIs should have argument validation and not Debug.Asserts

gfoidl opened this issue · 0 comments

Debug.Assert is like the name alludes only for development time. For runtime proper argument validations should be done for public APIs.

Or, as this comes with a small perf-drop, it should at least be documented that no validation is done, and it's subject to the caller of these API to provide valid arguments.

The status quo is that these APIs are really unsafe 😉 not just in some implementations, but from an API's point of view.