urban-health-labs/CombineFirebase

add SPM Support

lorenzofiamingo opened this issue · 8 comments

mobiletoly commented

Yes, please, that would be great.

kshivang commented

Follow this: firebase/firebase-ios-sdk#3136
firebase-ios-sdk is the bottleneck currently

tomatrow commented

@lorenzofiamingo Yeah, I couldn't get it working.

  • 😕1
quanshousio commented

@kshivang I just implemented support for SPM in #10, would you mind checking it out?

  • 👍1
kshivang commented

@quanshousio Sure looking into it

  • 👍1
dchakarov commented

I tried adding using SPM and got this error:
https://github.com/rever-ai/CombineFirebase has no Package.swift manifest for version 0.2.6
Is there something I'm missing?

Edit: I'm using Xcode Version 12.0 (12A7208)

quanshousio commented

@kshivang Can you tag the latest commit? If someone adds the package using version rule, Xcode will only fetch that repo up until the tagged commit.

@dchakarov For now, you can add the package using branch master.

dchakarov commented

@quanshousio using "master" seemed to work, thank you 💯

  • 🎉2