Add more complicated variable names

Question

Add more complicated variable names

Closed this issue 13 years ago · 11 comments

Currently all variables are alpha-only. We could use some numbers, underscores, dots and pct-encoded characters ( see: http://tools.ietf.org/html/rfc6570#section-2.3 ).

mnot commented 13 years ago

Yes.

Answer 1 · 2012-05-17T11:30:58.000Z

I've started on a few tests over here:

https://github.com/damnhandy/uritemplate-test/blob/master/extended-tests.json

Is this kind of what you were thinking @hannesg ?

Answer 2 · 2012-05-18T06:09:43.000Z

@damnhandy Yep, "last.name" and "Some%20Thing" are good examples.

Answer 3 · 2012-05-21T01:28:22.000Z

On second thought, I'm not so sure last.name is valid. Section 2.3 of the spec states:

     varspec       =  varname [ modifier-level4 ]
     varname       =  varchar *( ["."] varchar )
     varchar       =  ALPHA / DIGIT / "_" / pct-encoded

My ABNF skills are far from awesome, but if I read that correctly, the . isn't legal in a varname? Or am I just reading it wrong?

Answer 4 · 2012-05-21T02:16:42.000Z

According to that, not legal.

Cheers,

On 21/05/2012, at 11:28 AM, Ryan J. McDonough wrote:

On second thought, I'm not so sure last.name is valid. Section 2.3 of the spec states:
    varspec       =  varname [ modifier-level4 ]
    varname       =  varchar *( ["."] varchar )
    varchar       =  ALPHA / DIGIT / "_" / pct-encoded
My ABNF skills are far from awesome, but if I read that correctly, the . isn't legal in a varname? Or am I just reading it wrong?

Reply to this email directly or view it on GitHub:
#3 (comment)

Mark Nottingham http://www.mnot.net/

Answer 5 · 2012-05-21T08:31:48.000Z

Nope, is legal. You can read the spec as following:

A varspec is a varname optionally followed by a modifier-level4.
A varname is a varchar followed by a sequence of varchar each optionally preceded by ".".
A varchar is from ALPHA, DIGIT, "_" or pct-encoded.

It's legal but it may not be the first or last character.

Answer 6 · 2012-05-21T10:37:47.000Z

I think you're right @hannesg , I overlooked the quotes on ["."]. I thought it was optional string concatenation as in section 2.3 Like I said, my ABNF skills still need work ;)

Answer 7 · 2012-05-21T11:20:13.000Z

argh, missed that, sorry; I should have looked more closely.

Answer 8 · 2012-05-21T11:40:42.000Z

You're welcome ;)

Answer 9 · 2012-05-21T11:48:05.000Z

Making the fix...

Answer 10 · 2012-05-21T12:48:41.000Z

Think we can close this for now (though there may be more...)