spec-examples.json is missing cases
GrahamCampbell opened this issue · 2 comments
The readme says that all the cases from spec-examples-by-section.json are included in the spec-examples.json file, but this is not true. There are various missing examples.
Can you be more specific?
As I'm currently implementing Yet Another URI Template Parser as part of a broader piece, I've found a few gaps/challenges for the unsuspecting implementer. In this case, I'm also not 100% sure which test cases should be in which file, and to what extent they overlap or are super/sub sets of each other.
Looking at spec-examples.json, is it supposed to represent all cases of a specific level in the RFC, or just those cases detailed in the table in 1.2? It seems to be the latter, with a few missing cases (the fragment expansion examples from Level 2, a label expansion example (X{.keys*}) from Level 4) and the occasional added case (an errata-exercising case in Level 1 including "'" as an allowed literal character).
If it is meant to be just the examples given in the example table, with the rest of the examples in the RFC included in the section-specific spec-examples-by-section.json (and thus the union of the two being all test cases), would it be worth changing the wording in the README to make this clearer?