uscuni/sgeop

buffer value in `geometry.voronoi_skeleton()`

Closed this issue · 2 comments

jGaboardi commented

I'm curious if the following could be (buffer is None) or (buffer == 0):, or if cases have cropped up where a buffer=0 is truly the desired parameter?

sgeop/sgeop/geometry.py

Lines 133 to 134 in 199f20c

if buffer is None:
buffer = max_segment_length * 20

xref #25

martinfleis commented

I don't think should. If a user wants 0 for whatever reason, I'd let them do that.

  • 👍1
jGaboardi commented

Decision to leave as is.