usedbytes/picow_ds4

Missing files from btstack

Opened this issue · 9 comments

ux-lic commented

When I try to compile this code with cmake I get this error saying it cannot find avrcp_coverart_client.c

Any idea why it is looking for this file?

-- Configuring done (0.3s) CMake Error at src/CMakeLists.txt:13 (target_link_libraries): Cannot find source file:

/Users/dosho0/Github/picow_ds4/btstack/src/classic/avrcp_cover_art_client.c

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

Hi, that's strange.

Could you tell me what you've run to get to this point? I just tried a clean check-out and it's fine. The version of btstack that's pinned in the submodule does indeed not appear to have that file, but that doesn't cause me any issues, and I can't see any references to it in (that version) of the code.

Did you change the version of btstack?

The avrcp files which build for me are:

[ 52%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp.c.obj                                                                                                                                                                                    
[ 52%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing.c.obj                                                                                                                                                                           
[ 53%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing_controller.c.obj                                                                                                                                                                
[ 53%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing_target.c.obj                                                                                                                                                                    
[ 54%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_controller.c.obj                                                                                                                                                                         
[ 54%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_media_item_iterator.c.obj                                                                                                                                                                
[ 55%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_target.c.obj

I am getting the same error ux-lic is seeing.

OK I've reproduced and found the issue - see the issue I opened on pico-sdk above.

Basically I need to update my version of btstack to work with newer pico-sdk versions - but that means it will break for older pico-sdk versions. Which is annoying.

I've pushed an update to main which will hopefully fix your issues.

I was running into the same error, so I followed the breadcrumbs, but still ran into issues. I tried running git submodule update --init --recursive but I received an error saying:

Submodule 'btstack' (https://github.com/usedbytes/btstack) registered for path 'btstack'
Cloning into '/home/fank/Documents/pico/projects_bt/picow_ds4/btstack'...
fatal: remote error: upload-pack: not our ref 2382b034608370bf1dea2e7d59adba4deb8f9047
fatal: Fetched in submodule path 'btstack', but it did not contain 2382b034608370bf1dea2e7d59adba4deb8f9047. Direct fetching of that commit failed.
fatal: 

I tried using the hid_ds4 branch (and master) branch off your btstack fork, but no luck. Anyway I get the correct btstack version? I'd also like to note I rolled back my SDK to the correct hash listed in the readme. This repo would save my project! Any help would be appreciated. Thanks.

I've hit the same problem as Frank. It gives the error for both the master and rolled back versions of the pico_sdk.

Hi - could you please try again? Looks like I might have not pushed the updated btstack commit to my fork. I think I've fixed it now.

This worked for me thanks!

Works now thanks!