Additional SSH portal support
shreddedbacon opened this issue · 1 comments
With ssh-portals rolling out, tasks will need to potentially know how to generate a token via the token service that ssh-portal, we already inject some task variables that provide the SSH host and port etc, we should also provide a way to support X_TOKEN_HOST
and X_TOKEN_PORT
injection for future usage by those systems that can use it (
remote-controller/controllers/v1beta1/task_controller.go
Lines 152 to 179 in 3dbe104
These could also be used then in place of https://docs.lagoon.sh/using-lagoon-the-basics/lagoon-yml/#api and https://docs.lagoon.sh/using-lagoon-the-basics/lagoon-yml/#ssh, and endpoint
for things that consume these, like https://github.com/amazeeio/drupal-integrations and https://github.com/uselagoon/lagoon-service-images/tree/main/drush-alias
Actually, if ssh-portal
could accept token
and return the token from core, none of this is required. Currently there is a separate token
service for collecting a token which is fine, but if the portal is already talking to the ssh-portal-api to check access, it could also handle returning a token fairly easily