uselotus/lotus

Improving packaging

bioinfornatics opened this issue · 7 comments

bioinfornatics commented

Dear,
after a look to the code, to my point of view providing a mix of Pipfile and pyproject.toml do not aims a gold standard.
Ideally, the build process have to generate a distributable archive such as a wheel.
The generated wheel is mount to the container and installed with help pip

Thus I would recommend to use poetry, which help a lot and ease this process

Best regards

mnida commented

Hi,
Will loop in @diego-escobedo on the convo as he is the python lead on this project.

mnida commented

What do we think about Poetry vs pdm? @bioinfornatics

bioinfornatics commented

tooling is sometime subjective, I use poetry and fit well the needs. They are active and continue to add features.
if pdm is the right tools for you it is nice too
here I think the build process need to be well split:

  • build -> declare the main
    as example for a pyproject.toml
…
[tool.poetry.scripts]
lotus_backend = "lotus.backend.__main__:main"
…
  • archive -> wheel
  • install -> mount wheel to the container and pip install

thanks to this works and to provides such tools

mnida commented

@bioinfornatics Makes sense. I'm open to either poetry or pdm. I like how you broke down the process. Would you be open to starting this issue?

bioinfornatics commented

to give an insight to the road to take: #547

diego-escobedo commented

Hey @bioinfornatics never heard anything else from you on that PR you linked. The codebase has changed quite a bit since then so I'm closing this + the PR for now but feel free to reopen once the changes are a bit less drastic.