Check Address checksum in AddressUtils

Question

Check Address checksum in AddressUtils

gregzaitsev opened this issue 5 years ago · 7 comments

File:
src/utils/address.cpp

AddressUtils::getPublicKeyFromAddr method needs to throw ApplicationException in case if address checksum is wrong. The checksum is included in last 2 bytes of the address and verification process is described in the code comments in this method. Also, SS58 address format specification can be useful:

https://github.com/paritytech/substrate/wiki/External-Address-Format-(SS58)

Answer 1 · 2019-07-30T21:59:09.000Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$142,732.47 more funded OSS Work available on the Gitcoin Issue Explorer

Answer 2 · 2019-07-31T05:05:59.000Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 11 months, 4 weeks from now.
Please review their action plans below:

1) bakaoh has been approved to start work.

I fixed it here https://github.com/bakaoh/polkadot_api_cpp/blob/issue7/src/utils/address.cpp, It's reversal of getAddrFromPublicKey implement.
I also added a simple test case https://github.com/bakaoh/polkadot_api_cpp/blob/issue7/test/decode_public_key.cpp#L17

Learn more on the Gitcoin Issue Details page.

Answer 3 · 2019-07-31T09:35:35.000Z

Thank you, @bakaoh! This is a very quick and good quality work! I am asking to approve your contribution request.

Answer 4 · 2019-07-31T10:37:48.000Z

@bakatsar, would you mind to exchange contact information in case if have some collaboration opportunities? Please contract me at gz2019 at usetech.com

Answer 5 · 2019-07-31T22:12:04.000Z

@bakaoh once you submit work glad to payout

Answer 6 · 2019-08-01T00:47:52.000Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

@bakaoh

@Web3Foundation please take a look at the submitted work:

PR by @bakaoh

Learn more on the Gitcoin Issue Details page
Want to chip in? Add your own contribution here.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$145,911.33 more funded OSS Work available on the Gitcoin Issue Explorer

Answer 7 · 2019-08-05T15:47:12.000Z

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @bakaoh.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$145,200.32 more funded OSS Work available on the Gitcoin Issue Explorer