[RTMP] "too big message" (on big-endian platforms)

[jbubik]

Big-endian platforms (usually running OpenWrt) have a known issue in RTMP code. ARUT has started to deal with it in branch "big-endian" but never finished it. His changes never got into master. There are at least 3 open issues in his repo (sergey-dryabzhinsky#324 arut#576 arut#739) that describe the problem. I can confirm that package nginx-all-module in Openwrt 19.07.2 uses your source code (ut0mt8/nginx-rtmp-module) and still has the problem on MIPS. Log from nginx:

2020/05/12 21:20:52 [info] 14610#0: *9 client connected '192.168.11.41'
2020/05/12 21:20:52 [info] 14610#0: *9 too big message: 67108864 > 20971520 , client: 192.168.11.41, server: 0.0.0.0:1935
2020/05/12 21:20:52 [info] 14610#0: *9 disconnect, client: 192.168.11.41, server: 0.0.0.0:1935
2020/05/12 21:20:52 [info] 14610#0: *9 deleteStream, client: 192.168.11.41, server: 0.0.0.0:1935

I create this Issue to document current status. Suggested course of action is to review rtmp code and make it endian-agnostic. Unfortunately I have no time to do that now. It's a pity ARUT hasn't started using NTOH/HTON from the beginning.

Is the DASH implementation more robust (eg. is it tested on big-endian machines)?