uxlfoundation/oneTBB

TBB_BUILD_APPLE_FRAMEWORKS missing headers

Opened this issue · 4 comments

wtholliday commented

The frameworks generated by TBB_BUILD_APPLE_FRAMEWORKS have no headers. Is there a way to enable copying them? Does something need to be updated in CMakeLists.txt?

image

thanks!

wtholliday commented

There's this:

if(TBB_BUILD_APPLE_FRAMEWORKS)
    set_target_properties(tbb PROPERTIES
        FRAMEWORK TRUE
        FRAMEWORK_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_IDENTIFIER com.intel.tbb
        MACOSX_FRAMEWORK_BUNDLE_VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
        MACOSX_FRAMEWORK_SHORT_VERSION_STRING ${TBB_BINARY_VERSION})
endif()

Probably should also have a value for PUBLIC_HEADER

wtholliday commented

I tried adding PUBLIC_HEADER "../include/oneapi/tbb.h" but CMake doesn't stick the file in the framework, and also doesn't even print a warning.

wtholliday commented

Someone suggested that the headers should be added using add_library as well, as in the FRAMEWORK docs example. Doesn't seem like they are.