v8/node

Rebase to latest Node.js master, update to latest V8 ToT

ofrobots opened this issue · 4 comments

ofrobots commented

/cc @fhinkel @matthewloring @hashseed @targos

The vee-eight-lkgr branch has a version of Node.js master from more than 2 months ago. I am going to use this issue to rebase to the latest master along with pickup the V8 ToT from this morning.

I am going to reset the head to what I have on my fork presently, specfically 1735fdf. Since rebase is destructive on the history, I have created a backup tag lkgr-backup-20170214 pointing the to present head: 9e76b83.

A few tests are still disabled in this branch. Most of these are related to debug.

Issues that need to be addressed as a follow-on:

  • Debug::SetMessageHandler is a nop in V8 5.8. This means that node debug can no longer work. All the test using node debug should be migrated to use node inspect instead. I tried doing this, but was blocked by a bug that node --inspect-port=${port} doesn't seem to be getting propagated to the inferior. All instances of the node inspect inferior start on the same (default) port, causing grief. For now I have deleted the debug tests, but as a follow on these should be properly fixed.
  • test-intl-no-icu-data.js is a new test. I didn't have time to look into why it is failing.
  • I am not sure if the windows build issues have been addressed yet.
ofrobots commented

Local tests are passing on linux and mac. Pushed
1735fdf to vee-eight-lkgr on this repo.

ofrobots commented

I also had to disable test-dgram-address.js as it seems to fail in the CI https://build.chromium.org/p/client.v8.fyi/builders/V8%20-%20node.js%20integration/builds/3825

The test itself should be fine, but I think there might be some issue with ipv6 addresses in the V8 CI that cause it to break only in that environment:

not ok 225 parallel/test-dgram-address
  ---
  duration_ms: 0.88
  severity: fail
  stack: |-
    
    assert.js:85
      throw new assert.AssertionError({
      ^
    AssertionError: Unexpected error on udp6 socket. Error: bind EADDRNOTAVAIL ::1
        at Object.fail (/b/build/slave/node_js/build/node.js/test/common.js:496:10)
        at Socket.socket.on (/b/build/slave/node_js/build/node.js/test/parallel/test-dgram-address.js:47:12)
        at emitOne (events.js:96:13)
        at Socket.emit (events.js:189:7)
        at _handle.lookup (dgram.js:217:14)
        at _combinedTickCallback (internal/process/next_tick.js:77:11)
        at process._tickCallback (internal/process/next_tick.js:98:9)
        at Module.runMain (module.js:607:11)
        at run (bootstrap_node.js:422:7)
        at startup (bootstrap_node.js:143:9)
fhinkel commented

Thank you!