`app-theme.generated.js` gets generated inside resource dir instead of build dir when using themeFolder
christoph-frick opened this issue · 3 comments
Desktop (please complete the following information):
- OS:
Linux 5.10.0-6-amd64 Debian 5.10.28-1 - JDK version:
11.0.11 (Azul Systems, Inc. 11.0.11+9-LTS) - Gradle version: 6.8.3
- Vaadin Plugin version: 0.14.6.0
Describe the bug/To Reproduce
Given a 14.6.+ project using a matching plugin version (e.g. christoph-frick/try-vaadin14-gradle) utilizing the new features to override themes using @Theme(themeFolder='app-theme') and providing some actual theme content in src/main/resources/META-INF/resources/themes/app-theme/ a generated file end up in: src/main/resources/META-INF/resources/themes/app-theme/app-theme.generated.js.
The file gets not deleted by running the vaadinClean task.
Note, that the project runs fine (both bootRun and the generated JAR).
Expected behavior
Compile time artifacts end up under the build folder.
Hmm, sounds like a bug in Vaadin itself: vaadin/flow#10030
@christoph-frick if you agree, then this needs to be fixed upstream.
@mvysny I don't think I am qualified to give an answer here.
If there is nothing to do but to wait, I'd happily vote for closing this
ticket. And if you need to roll a version once it's fixed, IMHO keep it
open as a reminder -- but I am happy with whatever you decide to do.
After all this problem is just minute and does not prevent the use of
the feature or fail something under certain conditions.
Thank you, then i propose to keep this opened but mark it as blocked by an upstream bug, and let's see what happens.