vaadin/vaadin-tabs-flow

Investigate LitElement based web component version [1d]

Closed this issue · 2 comments

web-padawan commented

The latest version of vaadin-tabs component is this one:
https://github.com/vaadin/vaadin-tabs/releases/tag/v4.0.0-alpha3

There wasn't any breaking changes in component (properties are the same).

web-padawan commented

OK, it took me 10 minutes exactly as we supposed.

Findings:

  1. Need to downgrade Polymer to ^3.2.0 in @vaadin/themable-element.

  2. Need to update Lumo and Material in Flow (due to RTL)

After cleaning duplicate folders from node_modules the demos seem to be working.

The only regression is "Tabs with custom content" demo:

  • Polymer: checking the checkbox does not activate the tab
  • LitElement: checking the ckeckboc activates the tab
web-padawan commented

Closing in favor of vaadin/components-team-tasks#518 which covers all the components.