Example is wrong
PolpOnline opened this issue · 10 comments
The correct import while using TypeScript is
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";instead of
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";Please fix package.json to use let typescript detect the types declaration file
Thanks in advance
The correct import while using TypeScript is
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";instead of
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";Please fix package.json to use let typescript detect the types declaration file
Thanks in advance
Thank you! I'll fix this soon!
The correct import while using TypeScript is
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";instead of
import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";Please fix package.json to use let typescript detect the types declaration file
Thanks in advance
Don't forget that you can send PR ❤️
Nvm now Vite throws
Error: Missing "./dist" specifier in "@webzlodimir/vue-bottom-sheet" package
It doesn't work either way
It doesn't work either way
I tried to specify the dist folder and then it does not work, but it works fine if you do not specify the dist folder
What version do you use? Can you send me link to reproduce this bug?
Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.
You can refer to the details below. Hope this helps you in reproducing the bug!
Added VueBottomSheet on a branch on my project — i didn't pass any props since there's plenty of defaults set already: https://github.com/lyqht/styled-qr-code-generator/blob/dabb28acdfc5fc189c265312aec0ef4b99eb8a9a/src/App.vue#L656-L662
Typescript issue
Screenshots in trying to debug
EDIT: Here, I just realized i have to manually open the bottomsheet. It will be nice if there's a prop for us to just set if it is visible or not like how native bottom sheets usually implement that prop.
So after adding a basic onMounted function to open the bottom sheet, i can see it. But I cannot see its content or modify the width. Setting max-width=1000 doesn't help.
Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.
You can refer to the details below. Hope this helps you in reproducing the bug!
Hello! I will try to reproduce this bug today and get back to you with an answer right away
Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.
You can refer to the details below. Hope this helps you in reproducing the bug!
Hey! I released new 3.0.5 version, and fix bug with typescript typings, and fix width issue
You can't see the content because it is white text color)) just change its color
Hey there! thank you for getting back so fast. v3.0.5 fixed the TS & width issue for me!
There's some feature request issues that i'll raise separately later on, hope you don't feel stressed about those, those are just suggestions!