vacanza/holidays

Add Guinea holidays

Closed this issue · 4 comments

nalin-28 commented

I want to work on this. Also, Guinea has Lailat al-Qadr (https://www.timeanddate.com/holidays/guinea/laylat-al-qadr) as one of its public holidays and this holiday is not added in IslamicHolidays. So, can you assist me on how to add this to IslamicHolidays file.

  • 👍1
KJhellico commented

@nalin-28, as Lailat-al-Qadr also actual for Ivory Coast, so look at my suggestion about it.

nalin-28 commented

@KJhellico I saw the Ivory Coast Pull Request and Laylat al-Qadr has been implemented by Kriti Birda. So, should I take the code and implement it in my Pull Request too or should I wait till it gets added to the main branch?

KJhellico commented

You can add needed code to your branch for now, and when that PR will be merged, you can merge (if you'll have already published your PR by that time) or rebase (if not yet) on dev.

  • 👍2