Fix Carnival date of the "Portugal" calendar

[DgRosa]

Currently, the package incorrectly indicates that the Carnival "holiday" is on the Monday before the actual date, which in 2024 is 2024/02/13 (YYYY/MM/DD).
It's clear from the method name _add_carnival_monday().

This seems to be the problematic area.

I'm more than happy to open a PR.

Thank you for the excellent work 🚀!

[arkid15r]

Hi @DgRosa!

It seems self._add_carnival_monday(tr("Carnaval")) needs to be changed to self._add_carnival_tuesday(tr("Carnaval")), right?

I'm more than happy to open a PR.

We'd be happy to have another Python Holidays contributor!

[DgRosa]

Perfect, I'll do that then.

[DgRosa]

@arkid15r I don't have much experience contributing to open source projects, so I have some questions on how to proceed with the PR.
I see that the current PRs are from forks, is this what I should do or is it possible to create a branch and open a PR directly in this repository?
Thank you for your time.

[arkid15r]

Yes, we work with pull request based contributions. You won't be able to create a new branch due to lack of write permissions. You can read more about the PR based collaboration here.

[arkid15r]

@DgRosa thank you for the fix, it'll be included into today's release.