Consider making holiday object a first-class citizen
arkid15r opened this issue · 0 comments
arkid15r commented
The current PH version uses simple date/str pair as an item of dict-based holidays container.
Do we need/want to extend it to something more complex that would allow us having additional attributes on holiday object level (not only name, but also type/category, observance, other flags, etc)? Would the flexibility worth the efficiency trade-off (at this moment I can think of at least the new object size)?
This is based on an idea from #784 (comment). The interface example -- https://github.com/commenthol/date-holidays/blob/4596fb6c83c1339316529ae73c78e39646739488/types/index.d.ts#L55