Refactor Aruba/Curaçao as NL subdivision
Opened this issue · 3 comments
arkid15r commented
Feature Request
Description
Make sure Aruba and Curaçao are available as a subdiv of Netherlands (based on https://www.iso.org/obp/ui/en/#iso:code:3166:AW and https://www.iso.org/obp/ui/en/#iso:code:3166:CW).
Related Issues
N/A
Proposed Solution
- Move the
AW
andCW
holidays logic toNL
class. - Refactor Aruba logic to be based on
NL
's subdivAW
- Refactor Curaçao logic to be based on
NL
's subdivCW
Additional context
N/A
arkid15r commented
It seems logical to do the same for Aruba.
Absolutely! I've updated the issue. Thanks!
PPsyrius commented
Quick question here: Isle of Man, Jersey, and Guernsey were previously callable as Great Britain subdivisions before 2007: https://en.wikipedia.org/wiki/ISO_3166-2:GB as GB-IOM,
GB-GSY,
and GB-JSY
respectively. Should these entities get the same treatment, too?
Ideally, we should have ways to call up the appropriate holiday codes rather than folding them into the main entities. That would be great here.