vacanza/holidays

Implement Taiwan's unofficial holidays

Opened this issue · 2 comments

Bug Report

Expected & Actual Behavior

Labor Day is a holiday. but the information not in the module(holidays) - Taiwan class

Environment

  • OS: Windows 10
  • Python version: 3.11
  • holidays version: 0.54

Additional Context

The following is my use example, it will raise the Error. Cause the variable this_is_holiday not in tw_holidays.

import holidays
from datetime import datetime

Taiwan_labor_day = datetime(2024, 5, 1)
Double_tenth_Day = datetime(2024, 10, 10)
  
the_day = Taiwan_labor_day
  
tw_holidays = holidays.Taiwan()
this_is_holiday = the_day in tw_holidays
assert this_is_holiday

Thanks for reporting this @Curtis081
It seems there is a list of unofficial holidays that hasn't been covered yet.

I've updated the issue title based on that info.

Thank you for your attention and assistance! I have resolved the issue in my project by adding conditional statements.

By the way, there was a small problem with Python inspections: it showed the message "Cannot find reference 'Taiwan' in 'init.py.'"

Thanks again!