vacuumlabs/ledgerjs-cardano-shelley

messy address parameters types

Closed this issue · 1 comments

The current names for types related to address parameters are rather messy, and there is an old comment that perhaps no longer applies:

export type AddressParamsBase = SpendingParams & AddressParamsBaseStaking

// Not really worth the effort of disambiguation through additional tagged enum
export type AddressParamsBaseStaking =
| { stakingPath: BIP32Path }
| { stakingKeyHashHex: string }
| { stakingScriptHash: string}

It is part of the public interface, let's make it more consistent.

Resolved.