IBaseKoaProxiesOptions Should Extend http-proxy Server.ServerOptions
RavenHursT opened this issue · 0 comments
RavenHursT commented
Shouldn't this line include extends Server.ServerOptions
from the http-proxy
package?
https://github.com/vagusX/koa-proxies/blob/master/index.d.ts#L7
Considering the fact that it looks like the options object is being passed along wholesale to http-proxy
, seems like it would make sense: https://github.com/vagusX/koa-proxies/blob/master/index.js#L65-L70 and https://github.com/vagusX/koa-proxies/blob/master/index.js#L109
I was trying to add the buffer
option (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/http-proxy/index.d.ts#L187), but TS is choking on the missing property on IBaseKoaProxiesOptions
.