valeriansaliou/node-sonic-channel

TypeScript definition.

spacemeowx2 opened this issue · 6 comments

spacemeowx2 commented

I can make a PR if you don't mind

valeriansaliou commented

Hi! What would that be about? I'm not super native w/ TypeScript, can you tell me more? Wouldn't be a better idea to split this in a separate library built in ts?

spacemeowx2 commented

I'm going to write a TypeScript definition file (https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html). So I can use this library in TS without rewriting.

valeriansaliou commented

Got it. Please do, and submit a PR in this repository then. Please also update the README accordingly when you're done.

vokilam-d commented

@valeriansaliou Hello!
Can you please publish update to npm with this type definitions?

I'd really appreciate it

valeriansaliou commented

@vokilam-d just did, v1.2.6.

  • 👍2
shajia1992 commented

如果您不介意我可以做公关

大佬，直播助手对于企鹅平台的订阅失效，求修复