validator/htmlparser

Create a tombstone branch for nu.validator.encoding

hsivonen opened this issue · 5 comments

hsivonen commented

nu.validator.encoding is not ready for use and isn't being actively developed. I suggest I push a branch called encoding with the current snapshot and then delete the package from the master branch.

hsivonen commented

@sideshowbarker Are you OK with this? (I.e. having an encoding branch hanging around in case we ever want to resurrect this code.)

sideshowbarker commented

Yup, OK by me — thanks

hsivonen commented

Thanks. New branch, removal.

  • 👍1
carlosame commented

You should remove the encoding tests as well (test-src/nu/validator/encoding). This is the Maven build, currently:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project htmlparser: Compilation failure: Compilation failure: 
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/Big5Tester.java:[25,29] cannot find symbol
[ERROR]   symbol:   class Encoding
[ERROR]   location: package nu.validator.encoding
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/EncodingTester.java:[32,29] cannot find symbol
[ERROR]   symbol:   class Encoding
[ERROR]   location: package nu.validator.encoding
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/EncodingTester.java:[46,61] cannot find symbol
[ERROR]   symbol:   class Encoding
[ERROR]   location: class nu.validator.encoding.test.EncodingTester
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/EncodingTester.java:[239,61] cannot find symbol
[ERROR]   symbol:   class Encoding
[ERROR]   location: class nu.validator.encoding.test.EncodingTester
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/Big5Tester.java:[90,36] cannot find symbol
[ERROR]   symbol:   variable Encoding
[ERROR]   location: class nu.validator.encoding.test.Big5Tester
[ERROR] /var/repo/oss/htmlparser/test-src/nu/validator/encoding/test/Big5Tester.java:[94,36] cannot find symbol
[ERROR]   symbol:   variable Encoding
[ERROR]   location: class nu.validator.encoding.test.Big5Tester
hsivonen commented

Thanks. Removed.