Remove RedisEnterpriseCommandFlags for Valkey
dmitrypol opened this issue · 3 comments
dmitrypol commented
in commands.rs
#[derive(Debug, Deserialize)]
pub enum RedisEnterpriseCommandFlags {
/// A special enterprise only flag, make sure the commands marked with this flag will not be expose to
/// user via `command` command or on slow log.
ProxyFiltered,
}
impl From<&RedisEnterpriseCommandFlags> for &'static str {
fn from(value: &RedisEnterpriseCommandFlags) -> Self {
match value {
RedisEnterpriseCommandFlags::ProxyFiltered => "_proxy-filtered",
}
}
}
PingXie commented
I think we should remove it. The obvious branding issue aside, it also makes no sense to reference an architectural decision (proxy) that is not in the Valkey scope.
madolson commented
I agree, let's remove it