Extension icon barely visible with dark themes
Gitoffthelawn opened this issue · 11 comments
With dark themes, the extension icon is barely visible.
This is true in the toolbar, the overflow menu ("More tools...") and when a dark theme is applied to about:addons.
I know the first two locations can be rectified; I'm not sure about the last one.
Hm, for a long long time there's been an inverted icon set in theme_icons for the browser_actions. Just tested, works for me:
Not currently possible for about:addons, but this looks okay to me:
Your icon has looked like this for me forever pretty much. Something must not be right.
What theme are you using? Is the extension updated to the latest version? Completely silly suggestion but have you tried uninstalling and reinstalling it?
I'm using the stock FireFox dark theme, and it's like this on my laptop as well on a brand new install of FireFox.
As I said, I think something that's supposed to be working here just isn't.
Oh. Damn. This is really stupid. So the theme color thing has only been working on HiDPI displays because of the size even though it's all SVG. I'll report this on bugzilla, and add an entry with smaller size for now.
Submitted 1.2.2 to Mozilla. Angry comment: here :)
yay, thanks for fixing it :)
it's such a small thing but it made my night
@unrelentingtech Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?
Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?
It's correct, "can be unused" of course. Maybe I should've just said "IS unused".
Is the 8th word of your bugzilla comment supposed to be "can" or "cannot"?
It's correct, "can be unused" of course. Maybe I should've just said "IS unused".
Ah, thanks. Now I see what you are saying. Yes, "IS unused" or "WILL BE unused" is clearer. Maybe worth an edit... maybe not. ;)