valpackett/soundfixer

Not saving settings

Closed this issue · 8 comments

idk if I'm doing anything wrong but it's not saving and so it doesn't work
https://github.com/valpackett/soundfixer/assets/64313768/b9c29556-b19f-466e-a2bc-e6ee66ef6c02

What page is this? Does this issue happen on e.g. YouTube?

I get the same issue on YouTube.

Possibly related, if I visit about:debugging#/runtime/this-firefox and debug SoundFixer, when I open the popup I see:

Navigated to moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.html
tab 389 frame 2334314725377 Error: Missing host permission for the tab or frames popup.js:77:26
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:60
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:59
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:57
tab 389 frame 2334314725385 Error: Missing host permission for the tab or frames popup.js:77:26
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:60
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:59
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:57
tab 389 frame 2334314725389 Error: Missing host permission for the tab or frames popup.js:77:26
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:60
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:59
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:57
tab 389 frame 2334314725393 Error: Missing host permission for the tab or frames popup.js:77:26
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:77
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:60
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:59
    (Async: promise callback)
    <anonymous> moz-extension://1bab01b4-53c8-45ab-b5e7-c8a14e86d5c2/popup.js:57
Navigated to chrome://devtools/content/shared/webextension-fallback.html#soundfixer@unrelenting.technology 

Cannot reproduce by starting with a clean temporary profile, installing SoundFixer and trying YouTube. Which version of Firefox are you all using?

  • Firefox 127.0.1 (64-bit) on Windows 11 x64 (old version, some hacked-up cleaned-up image I want to replace someday)
  • open new profile
  • refresh firefox
  • install ub0
  • install soundfixer
  • visit https://www.youtube.com/watch?v=oavMtUWDBTM
  • open soundfixer and change volumes
  • close and reopen popup
    • popup changes missing visually even though they're still applied to the sound
    • extension Developer Tools shows one tab 2 frame 17179869197 Error: Missing host permission for the tab or frames every time popup opens (both initially and after changing settings earlier)

Ohhhhh. Wait. I thought "it's not saving and so it doesn't work" meant it doesn't apply.

This is just #57 again – I guess I'll have to save the last applied "all media" volume since it's so confusing for everyone.

Ohhhhh. Wait. I thought "it's not saving and so it doesn't work" meant it doesn't apply.

This is just #57 again – I guess I'll have to save the last applied "all media" volume since it's so confusing for everyone.

Yeaaah no, for me it's not just visual, volume doesn't change either. Im using latest firefox version

@Wojti9 What page is this? Does this issue happen on e.g. YouTube?

Note:

image

@Wojti9 What page is this? Does this issue happen on e.g. YouTube?

Note:

image

@valpackett I don't remember what's the website I was using in the video but yes, it also happen on YouTube