Deprecation warning in Gnome 3.36

[szpak]

After upgraded to Fedora 32, Gnome Shell 3.36.5 i see the following deprecation warning (3 times) in the system log:

gnome-shell[16470]: Usage of object.actor is deprecated for DateMenuButton
    get@resource:///org/gnome/shell/ui/environment.js:287:29
    enable@/home/foobar/.local/share/gnome-shell/extensions/binaryclock@vancha.march/extension.js:244:7
    _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:166:32
    _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:492:18
    _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:491:11

The plugin seems to function correctly, however, if possible it would be probably good to change calls to non deprecated before they are effectively removed in the future.

Tested with a version from master.

[szpak]

When unlocked after suspend the stacktrace is slightly longer:

gnome-shell[16470]: Attempting to add actor of type 'StBin' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'.
gnome-shell[16470]: Usage of object.actor is deprecated for DateMenuButton
    get@resource:///org/gnome/shell/ui/environment.js:287:29
    enable@/home/foobar/.local/share/gnome-shell/extensions/binaryclock@vancha.march/extension.js:246:5
    _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:166:32
    _enableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:603:22
    _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:602:37
    _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:630:18
    _emit@resource:///org/gnome/gjs/modules/core/_signals.js:133:47
    _sync@resource:///org/gnome/shell/ui/sessionMode.js:195:14
    popMode@resource:///org/gnome/shell/ui/sessionMode.js:163:14
    _continueDeactivate@resource:///org/gnome/shell/ui/screenShield.js:499:30
    deactivate/<@resource:///org/gnome/shell/ui/screenShield.js:490:44
    finish@resource:///org/gnome/shell/gdm/authPrompt.js:523:13
    finish@resource:///org/gnome/shell/ui/unlockDialog.js:867:26
    deactivate@resource:///org/gnome/shell/ui/screenShield.js:490:26
    ScreenShield/</<@resource:///org/gnome/shell/ui/screenShield.js:109:57
    _emit@resource:///org/gnome/gjs/modules/core/_signals.js:133:47
    _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:169:19

(possibly the first line can be from some other extension)

[vancha]

Thank you for creating this bug report :) I'll be diving in to this plugin again this weekend since it seems to crash for newer versions of ubuntu, and I'll go over this issue as well. Hopefully it'll be fixed after the weekend ^^

[szpak]

I upgraded to Gnome 40 and (after manually bumping compatible versions indicator to include "40") the extension from master still works (but still with the aforementioned warning).

It might be useful to upload new version to https://extensions.gnome.org/ (and maybe along the way fix the warning ;-) )