Instant App Support

Question

dazza5000 opened this issue 7 years ago · 7 comments

This plugin doesn't look like it works on Android Instant Apps

Answer 1 · 2018-01-25T10:35:08.000Z

That's true. It's missing a few things here.

This project does check for the other variants.

Mind coming up with a PR to fix that?

Answer 2 · 2018-01-25T13:31:21.000Z

I would be up for it - could you provide some pointers? Thank you! Darran

Answer 3 · 2018-01-25T13:31:56.000Z

Yeah it's the first link that I posted and then the second link shows the possible plugin ids.

Answer 4 · 2018-01-25T14:17:13.000Z

Could you give me one more hint of what I should do with those?

On Jan 25, 2018 7:31 AM, "Niklas Baudy" ***@***.***> wrote: Yeah it's the first link that I posted and then the second link shows the possible plugin ids. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABENMXoQUKlZQ1JjPBu5C90jTTowXc2Pks5tOIJMgaJpZM4RrmgJ> .

Answer 5 · 2018-01-25T14:34:21.000Z

You need to add those checks in here.

Answer 6 · 2018-01-25T23:01:03.000Z

I submitted a pull request. Please let me know if there is anything I need to include/change. Darran

On Thu, Jan 25, 2018 at 8:34 AM, Niklas Baudy ***@***.***> wrote: You need to add those checks in here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABENMbEXEpDYSLQQLvbboYYROKT2MlhTks5tOJDugaJpZM4RrmgJ> .

Answer 7 · 2018-01-26T10:30:39.000Z

Fixed by #111