vanniktech/gradle-android-junit-jacoco-plugin

Plugin does not work with Gradle 8.0

Laimiux opened this issue · 10 comments

Laimiux commented

JacocoMerge task was removed (gradle/gradle#12767) and this plugin now throwa

Failed to apply plugin 'com.vanniktech.android.junit.jacoco'.
> Could not create plugin of type 'GenerationPlugin'.
   > Could not generate a decorated class for type GenerationPlugin.
      > org/gradle/testing/jacoco/tasks/JacocoMerge
vanniktech commented

Honestly, this is super unmaintaned. Happy for a person to jump in

  • 👍9
twyatt commented

@Laimiux any plans to get your Gradle 8 support (laimonas/gradle-8 branch) merged into this project? Or, to publish your fork publicly? 🙏

Laimiux commented

I've got it to work for and published it to internal maven repository (at Instacart). I'm leaving for vacation for two weeks starting tomorrow so I won't be able to work on merging this back into here. However, if anyone has bandwidth, the changes in https://github.com/Laimiux/gradle-android-junit-jacoco-plugin/tree/laimonas/gradle-8 should be easy to contribute back.

  • ❤️2
twyatt commented

Honestly, this is super unmaintaned.

@vanniktech if PRs are created/merged, will you continue to publish versions? Or, are you hoping someone will fork this project and publish as a new artifact?

  • 👀2
tecruz commented

Any news?

themockgraeme commented

@vanniktech I forked Gradle 8 branch that @Laimiux created, removed some added publishing code which I suspect is specific to the Instacart repository, and updated some of the imported libraries. It's now building with Gradle 8 / Java 17.

I created a pull request, and the code can be found at:

https://github.com/themockgraeme/gradle-android-junit-jacoco-plugin/tree/gradle-8-upgrade

  • ❤️6
vramasam commented

Hello @themockgraeme Is there any new artifacts available for the above fix. If its there can you please provide the path

themockgraeme commented
vramasam commented

Okay @themockgraeme . Thank you for the response. Is there any plan to update this to master and create a tag and publish?

themockgraeme commented

@vramasam I haven't really thought about it. I migrated the project that I'm working on to an alternative plugin.

https://github.com/gmazzo/gradle-android-test-aggregation-plugin

I'm busy for the next week and a half, but after that I might take a quick look at the project and get it compiling, but it's not something that I'm looking at taking on and maintaining.

  • 👍1