vapor/console-kit

Not compiling for other platforms

rocketnik opened this issue · 3 comments

rocketnik commented

Hi,

could you please add to Terminal.swift line 82:

#else
            var pass = ""

This fixes compilation for other platforms. In my case I have an iOS project, that shares some API with the backend and that depends on async-kit -> console-kit. I know, that my dependencies are too strong and that the API models should have less dependencies, but they are managed externally so I have less influence there. If console-kit compiled for other platforms as well with the above lines, it would be nice and solves the problem. Maybe add a #warning, that the current platform is not supported in the #else case.

If you rather want a pull request, let me know.

siemensikkema commented

@rocketnik are you using the latest version? This exact issue was the topic of #157 which got released as 4.2.5.

0xTim commented

Closing as this should be resolved in #157

@rocketnik feel free to reopen if it's still a problem!

rocketnik commented

Thank you, will try, and let you know, in case I still have issues.