vapor/fluent-mysql-driver

Make `MySQLConfiguration` non-constant

0xTim opened this issue · 6 comments

0xTim commented

We should allow the configuration in MySQLConfiguration to be changed by changing the properties to vars. This matches Postgres and makes it easier to set things like the TLSConfiguration

lodenrogue commented

I can give this a try

lodenrogue commented

PR: #212

Please review it. I've never worked with swift before and I have no way to test locally.

fananek commented

I’m afraid you edited wrong file. Issue is about MySQLConfiguration properties.

All these lets shall be changed to vars.

lodenrogue commented

Got it. I'll make that change

  • 👍1
lodenrogue commented

PR: vapor/mysql-kit#309

I think a better approach is to just create a new MySQLConfiguration object and keep the fields immutable. But here's the change you requested in case you still want it.