vapor/vapor

Default to `HTTPClient.shared` when possible

MahdiBM opened this issue · 1 comments

See https://github.com/swift-server/async-http-client/releases/tag/1.21.0
We can default to that when users haven't provided a default configuration.
The default configuration should also be changed to .singletonConfiguration if that doesn't seem too much of a behavior change, because that configuration:

tries to mimic the platform's default or prevalent browser as closely as possible.

0xTim commented

This is primarily aimed at application developers. Since we can control the lifecycle of the client, the guidance is to continue to use our client we instantiate