varnish/hitch

Static fchown instead of permission check

alkuzad opened this issue · 0 comments

Expected Behavior

Logfile can be set to /dev/stdout

Current Behavior

Instead of doing fchown every time, check permissions and do it if needed. This breaks using /dev/stdout which is root owned but it's 777

hitch/src/hitch.c

Line 4192 in c8033c3

AZ(fchown(fileno(logfile), CONFIG->UID, CONFIG->GID));

Possible Solution

Do fchown only if write is not possible

Steps to Reproduce (for bugs)

  1. Set logfile config to /dev/stdout
  2. Start hitch

Context

This makes it hard to make sure container logs to stdout instead of stderr

Your Environment

Docker container - alpine:3.11, run as non-priviledged user