vasi/squashfuse

Why is the compressed bit being set in inode headers when its size is 0?

Closed this issue · 3 comments

mgord9518 commented

I've been reading through SquashFS documentation and I've been unable to find anything indicating that the compressed bit should be set if the size is 0, what is the purpose of this code?

squashfuse/fs.c

Lines 137 to 138 in 94f998c

if (!*size)
*size = SQUASHFS_COMPRESSED_BIT;

vasi commented

I don't know why it's not documented, but it's what the kernel does: https://github.com/torvalds/linux/blob/50dffbf771802c4db88de2cb942affa0ada43ad0/fs/squashfs/squashfs_fs.h#L108

  • 👍1
mgord9518 commented

@vasi I asked the author of SquashFS, apparently it only pertains to SquashFS 1.0 so it should be safe to remove

vasi commented

Oh nice, thanks for the followup.

  • 👍1