vaulttec/sonar-auth-oidc

"?return_to=/projects" seems to be ignoring sonar.web.context

Closed this issue · 2 comments

tonihoang commented

When I am redirected form my OIDC provider I get returned to {mydomain}/projects, which is not found.

Shouldn't it take the sonar.web.context into account?

I have not found anything in code except:

sonar-auth-oidc/src/main/java/org/vaulttec/sonarqube/auth/oidc/AutoLoginFilter.java

Line 39 in 84019fb

private static final String OIDC_URL = "/sessions/init/" + OidcIdentityProvider.KEY + "?return_to=/projects";

but this is hardcoding "/projects" I assume it should contain the config.getBaseUrl()?

-->

private static final String OIDC_URL = "/sessions/init/" + OidcIdentityProvider.KEY + "?return_to=" + config.getBaseUrl() + "/projects";

to be correct?

As I am unable to test it right now I did not create a PR yet.

tjuerge commented

Thanks for spotting that.

tonihoang commented

Created a PR #56

But did not go through everything so that would be a quick fix