vc1492a/tidd

Improve speed of tests by reducing test data sizes

vc1492a opened this issue · 7 comments

vc1492a commented

The tests currently take a long time to run since they use the entirety of the experimental data to perform tests. Instead, sample datasets should be created as part of the testing suite using (by using fixtures) so that testing isn't reliant on experimental data.

As a result, this would dramatically reduce the dataset sizes used in testing and improve the speed of the unit tests.

vc1492a commented

@hamlinliu17 any updates on this issue?

  • 👍1
hamlinliu17 commented

@vc1492a Sorry haven't done much this weekend since I was moving in. Will commit and push what I have by tonight.

hamlinliu17 commented

@vc1492a I have improved the test for read_day, might need to work on the test for normalize since the total unit testing is still ~40 secs. Big improvement from the 6 minutes that it used to take 😃. Here is the commit

hamlinliu17 commented

@vc1492a Got the test down to 6 seconds 😃 but I am not sure if my random data generator is fine for unit testing

vc1492a commented

Nice!!! Let's go over those changes during our call this Friday 🚀

hamlinliu17 commented

@vc1492a Submitted a PR here

vc1492a commented

Recently merged this work from the PR mentioned above into the dev branch - closing!