vebr/jest-lcov-reporter

Comment is updated even with option in false

Opened this issue · 5 comments

Deleted user commented

I have a workflow with two different jobs which each of them has this GA action.

 - name: Publish code coverage report
    uses: vebr/jest-lcov-reporter@v0.2.1
     with:
        github-token: ${{ github.token }}
        name: Client Portal Coverage Report
        lcov-file: webapps/client-portal/coverage/lcov.info
        update-comment: false

- name: Publish code coverage report
    uses: vebr/jest-lcov-reporter@v0.2.1
    with:
       github-token: ${{ github.token }}
       name: Qualifications Portal Coverage Report
        lcov-file: webapps/qualifications-portal/coverage/lcov.info
        update-comment: false

The issue is always there is only one comment created and it's being updated, so I never have the two comments.

ricardovanlaarhoven commented

Warning: Unexpected input(s) 'update-comment', valid inputs are ['github-token', 'lcov-file', 'lcov-base']

ricardovanlaarhoven commented

The latest release github action failed, that release included this feature. Please take a look into that.
i'd love to help but i cant check the logs or run the command

alexjfno1 commented

The issue is always there is only one comment created and it's being updated, so I never have the two comments.

At the moment, if update-comment is enabled, it will only leave one comment per workflow as it uses the workflow name as the unique identifier. The feature would need to be enhanced if you wanted to update more that one comment per workflow.

As for the update-comment: false, I will see if I can reproduce the issue.

alexjfno1 commented

@ricardovanlaarhoven Initial investigations look like the getInput only returns string values - actions/toolkit#361 which means that checking the input value returns "false" which evaluates to be true.

We need to use the new getBooleanInput - actions/toolkit#725

I will try to get a PR raised 😃

  • 👍1