vedderb/vesc_tool

VESC Tool closes with version check failure when vesc-project.com is not online

Opened this issue · 2 comments

void Utility::checkVersion(VescInterface *vesc)

No handling for vesc-project.com being in some broken state, so vesc tool just closes itself after 10s.

Workaround is to disconnect network from the device running vesc tool.

Looks like this is a blocking call:

loop.exec();

So if the HTML response is dragged out, then this will block.

Also, there's not sanity checking of the returned result. A garbled response might cause unexpected behavior.

Well, vesc-project.com is down again and the current dev version build with qtcreator appears to still work. So this is probably fixed?

Edit: Possibly a false alarm / not a real test. Access to vesc-project.com resolved after power cycling my router. (weird that other websites worked fine though)

Looking at the code, the blocking call does not appear to have been wrapped in any sort of timeout or error handling. So probably not fixed.