vegaprotocol/specs

[Feature]: Make relative PNL reward only reward realised PnL

Closed this issue · 4 comments

JonRay15 commented

Feature Overview

In order to improve the current games functionality
We will look into these hopefully "quick fixes"
So that people find the games more engaging

Tasks

  • Create a new reward type for REWARD_RELATIVE_RETURN_REALISED which will only look at realised PNL in the epoch

Feature test scenarios

Detailed scenarios that can be executed as feature tests to verify that the feature has been implemented as expected.

GIVEN (setup/context)
WHEN (action)
THEN (assertion) For example...
See here for more format information and examples.

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

barnabee commented

Based on what I've seen in Discord chat plus observing the wild variation in number of eligible/rewarded teams because of the positive P&L requirement, I think these would be welcome changes.

It'd also be good to expose the metrics and/or the raw data counters that go into them live or at least in regularly updating snapshots via APIs so that a leaderboard can be produced that updates during the epoch. This would also help users understand the how/why of reward distributions by the prorotocol at epoch end.

JonRay15 commented

Added that secone part here: #2239

Since it is a quite different task to the other stuff listed above

daunatv commented
  • Relative return •
    Realised PnL instead of unrealized and realized? Makes users to be a bit more active not just hold.
JonRay15 commented

I think realized PnL might be a bit more intuitive than having a running volume requirement because

  1. That running vol requirement feels a bit forced, it is more organic to say "i need to lock in X profit this epoch for it to count" than "I need X profit overall but need to make sure I've done Y running volume for it to count"
  2. Plus currently I dont think we can expose that running volume during the epoch so until we have that available it will be a bit of a guessing game whether you have hit it or not.
  3. Its easier as a trader to keep track of your realized PnL through the day ... you just need to know what it was at the end of the last epoch and what it is right now and you know what you've managed