vegardit/docker-gitea-act-runner

workflows/build.yml fails to push built images to registry

wblew opened this issue · 2 comments

wblew commented

I noticed that the PR #6 changes were not present in images built after its merge.

To reproduce, run:
docker run --rm vegardit/gitea-act-runner:latest cat /opt/run.sh
Observe that that run.sh contains:
sudo usermod -o -u "$GITEA_RUNNER_GID" act
Rather than:
sudo usermod -o -g "$GITEA_RUNNER_GID" act

After an investigation, I think the situation can be traced to these lines (with DOCKER_PUSH=0):

$(if [[ "${DOCKER_PUSH:-0}" == "1" ]]; then echo -n "--push"; fi) \
"$@"
docker buildx stop
docker image pull $image_name

Adding mult-arch building, changed the BuildKit builder from the docker driver, to the docker-container driver.

However, the docker-container driver does not load its built images into the job container's docker engine registry.

Result? The docker pull at L50, pulls stale arch specific images built before the multi-arch merge commit 313f378.

Thanks for reporting. I changed the build script. Please check again.

wblew commented

Checked, and confirmed it's fixed.