vegeta897/snow-stamp

If an invalid snowflake is entered, the URL query parameter of the snowflake gets stuck at the invalid snowflake

Closed this issue · 2 comments

Screenshot_188
Like in this screenshot, if you enter an invalid snowflake, it gets stuck at that snowflake and you have to re-enter a valid snowflake into the URL for it to work again.

Thanks for reporting, I will check this out!

Update just to explain what was wrong:

All invalid snowflakes should have been caught and resulted in an error message displayed on the page instead of showing "Invalid Date" in the output display. The app was already smart enough to not put an invalid snowflake in the URL but only if the error was caught properly. In this case, I hadn't accounted for numbers that were large enough to cause invalid dates. Now that this is caught, the URL remains safe.

Screenshot_229
Alright, everything looks good now.